feat(web): add workspace-aware terminal panel layout by justsomelegs · Pull Request #1690 · pingdotgg/t3code

justsomelegs · 2026-04-02T15:29:11Z

What Changed

Added workspace-aware terminal layout options in the web app.

Workspace scoped terminal (full-width)	Right panel side terminal

example.mp4

This PR:

adds terminal position settings for bottom and right
adds bottom terminal scope settings so the bottom terminal can either:
- match the chat width, or
- span the full workspace width
moves terminal placement out of ChatView and into the route/workspace layout
replaces the old terminal drawer naming with ThreadTerminalPanel
adds a shared right-side workspace panel so diff and terminal can use the same right rail
makes the wide right rail use the shared sidebar primitive again, with an inline/workspace mode
keeps narrow right-side behavior as a sheet
adds persistence for linked vs independent right-rail widths
fixes Windows startup issues caused by invalid terminal open/resize dimensions
removes the left terminal position after trying it and deciding it was not a good fit

Why

The built-in terminal was previously hard-wired to a bottom drawer inside the chat area. That caused a few UX problems:

the bottom terminal could not span the full workspace when the diff panel was open
there was no way to place the terminal on the right
the right-side diff and terminal could not share one clean panel
terminal layout logic was tied too closely to chat rendering

This approach keeps the bottom workspace-scoped terminal working while making the terminal placement a real workspace concern instead of a chat-only concern. It also reuses the shared sidebar primitive for the wide right rail so the panel behavior is much closer to the existing main-branch sidebar behavior instead of relying on a separate custom animation system.

UI Changes

Before:

terminal only opened as a bottom drawer inside the chat area
bottom terminal width was constrained by the chat column
no right-side terminal option
diff and terminal could not share a single right panel

After:

terminal can be positioned at the bottom or on the right
bottom terminal can either match chat width or span the full workspace
right-side terminal uses the same right workspace rail as diff
on narrow screens, right-side terminal falls back to a sheet
right rail width can be linked with diff or remembered separately

Checklist

This PR is small and focused
I explained what changed and why
I included before/after screenshots for any UI changes
I included a video for animation/interaction changes

Note

Add workspace-aware terminal panel layout with right-rail docking and position settings

Renames ThreadTerminalDrawer to ThreadTerminalPanel throughout and adds layout ('bottom' | 'side') and bottomScope ('chat' | 'workspace') props that control resize behavior, split orientation, and height clamping
Introduces a shared right rail in the chat thread route that hosts either the diff panel or the terminal, with mutual exclusivity enforced by a new useWorkspacePanelController hook
Adds resolveWorkspacePanels to derive docking targets (bottom-inline, bottom-workspace, right) and sheet/rail visibility flags; terminal renders into its target via React portal using WorkspaceTerminalPortalTargetsContext
Exposes three new user-configurable settings (terminalPosition, terminalBottomScope, terminalRightRailWidthMode) with UI controls in the General settings panel and legacy 'left' position migrated to 'bottom'
Adds shouldAcceptWorkspaceSidebarWidth to guard sidebar resize against composer minimum-width constraints
Risk: switching terminalPosition to 'right' makes the diff and terminal panels mutually exclusive in the right rail — opening one closes the other

^{Macroscope summarized 27c0886.}

coderabbitai · 2026-04-02T15:29:18Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 6766f35d-4ab5-4e60-9132-2d973b38b021

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

apps/web/src/routes/_chat.$threadId.tsx

macroscopeapp · 2026-04-02T15:33:20Z

Approvability

Verdict: Needs human review

This PR adds a substantial new feature allowing users to configure terminal panel positioning (bottom vs right side) with multiple layout modes and new settings. The scope includes new components, new state management hooks, and changes to panel coordination logic—warranting review to ensure the new UI behavior and settings work as intended.

^{You can customize Macroscope's approvability policy. Learn more.}

apps/web/src/components/ThreadTerminalPanel.tsx

…/justsomelegs/t3code into t3code/terminal-layout-and-shell

github-actions bot added size:XXL 1,000+ changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Apr 2, 2026

macroscopeapp bot reviewed Apr 2, 2026

View reviewed changes

apps/web/src/routes/_chat.$threadId.tsx Outdated Show resolved Hide resolved

justsomelegs force-pushed the t3code/terminal-layout-and-shell branch from 2c154b3 to 84bc1fd Compare April 4, 2026 21:00

macroscopeapp bot reviewed Apr 4, 2026

View reviewed changes

apps/web/src/components/ThreadTerminalPanel.tsx Show resolved Hide resolved

justsomelegs added 5 commits April 5, 2026 16:21

Add workspace-aware terminal panel layout

4bb7748

Avoid persisting workspace right rail state

af7f1fd

Refactor workspace terminal panel controls

7c26f6c

Fix terminal panel event subscription after rebase

0a65b83

Adjust terminal splits for side panel layout

ab93ba4

justsomelegs force-pushed the t3code/terminal-layout-and-shell branch from 66628e5 to ab93ba4 Compare April 5, 2026 15:22

justsomelegs added 2 commits April 5, 2026 17:59

Merge remote-tracking branch 'upstream/main' into HEAD

0927f0f

Merge branch 'main' into t3code/terminal-layout-and-shell

07aa2b9

justsomelegs mentioned this pull request Apr 6, 2026

[Feature]: Terminal Docking to the right #1773

Open

3 tasks

justsomelegs added 10 commits April 6, 2026 18:04

Merge branch 'main' into t3code/terminal-layout-and-shell

39fbc69

Merge branch 'main' into t3code/terminal-layout-and-shell

44be852

fix linting issues from bas merge

c5b57f5

Merge branch 'main' into t3code/terminal-layout-and-shell

e192feb

fix linting issues from bas merge

d422b59

Merge branch 't3code/terminal-layout-and-shell' of https://github.com…

07f7852

…/justsomelegs/t3code into t3code/terminal-layout-and-shell

Merge branch 'main' into t3code/terminal-layout-and-shell

cb376db

fix linting issues from bas merge

71282d7

Merge branch 't3code/terminal-layout-and-shell' of https://github.com…

b8d47f1

…/justsomelegs/t3code into t3code/terminal-layout-and-shell

Merge branch 't3code/terminal-layout-and-shell' of https://github.com…

27c0886

…/justsomelegs/t3code into t3code/terminal-layout-and-shell

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(web): add workspace-aware terminal panel layout#1690

feat(web): add workspace-aware terminal panel layout#1690
justsomelegs wants to merge 17 commits intopingdotgg:mainfrom
justsomelegs:t3code/terminal-layout-and-shell

justsomelegs commented Apr 2, 2026 •

edited by macroscopeapp bot

Loading

Uh oh!

coderabbitai bot commented Apr 2, 2026 •

edited

Loading

Review skipped

Uh oh!

Uh oh!

macroscopeapp bot commented Apr 2, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

justsomelegs commented Apr 2, 2026 • edited by macroscopeapp bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Changed

Why

UI Changes

Checklist

Add workspace-aware terminal panel layout with right-rail docking and position settings

Uh oh!

coderabbitai bot commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

Uh oh!

macroscopeapp bot commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Approvability

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

justsomelegs commented Apr 2, 2026 •

edited by macroscopeapp bot

Loading

coderabbitai bot commented Apr 2, 2026 •

edited

Loading

macroscopeapp bot commented Apr 2, 2026 •

edited

Loading